Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments

Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments

Remove the 'Impl entirely, and put the details into the class itself.

Committed: https://pdfium.googlesource.com/pdfium/+/4ee98cd67354a2ab26134c0688768d4aa92350a2

[Tom Sepez, 2016-06-01 23:31:15]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-06-01 23:31:16]

Lei, for review. Srsly.

[Lei Zhang, 2016-06-01 23:42:52]

lgtm

https://codereview.chromium.org/2036513002/diff/1/xfa/fxjse/class.h
File xfa/fxjse/class.h (right):

https://codereview.chromium.org/2036513002/diff/1/xfa/fxjse/class.h#newcode33
xfa/fxjse/class.h:33: CFXJSE_Class(CFXJSE_Context* lpContext)
explict

[Tom Sepez, 2016-06-01 23:47:15]

https://codereview.chromium.org/2036513002/diff/1/xfa/fxjse/class.h
File xfa/fxjse/class.h (right):

https://codereview.chromium.org/2036513002/diff/1/xfa/fxjse/class.h#newcode33
xfa/fxjse/class.h:33: CFXJSE_Class(CFXJSE_Context* lpContext)
On 2016/06/01 23:42:52, Lei Zhang (OOO) wrote:
> explict

Done.

[Tom Sepez, 2016-06-01 23:47:19]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-06-01 23:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2036513002/#ps20001
(title: "Explicit ctor")

[commit-bot: I haz the power, 2016-06-01 23:47:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2036513002/20001

[commit-bot: I haz the power, 2016-06-01 23:58:27]

Description was changed from

==========
Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments

Remove the 'Impl entirely, and put the details into the class itself.
==========

to

==========
Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments

Remove the 'Impl entirely, and put the details into the class itself.

Committed:
https://pdfium.googlesource.com/pdfium/+/4ee98cd67354a2ab26134c0688768d4aa923...
==========

[commit-bot: I haz the power, 2016-06-01 23:58:28]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4ee98cd67354a2ab26134c0688768d4aa923...