Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1947)

Unified Diff: xfa/fxjse/dynprop.cpp

Issue 2036513002: Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Explicit ctor Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fxjse/class.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxjse/dynprop.cpp
diff --git a/xfa/fxjse/dynprop.cpp b/xfa/fxjse/dynprop.cpp
index 6e98d824e3855d884f906afd994f68d367df35ad..946fe42c1b5c1cd50371d06314cbf68e697b12f8 100644
--- a/xfa/fxjse/dynprop.cpp
+++ b/xfa/fxjse/dynprop.cpp
@@ -22,9 +22,8 @@ static void FXJSE_DynPropGetterAdapter_MethodCallback(
new CFXJSE_Value(info.GetIsolate()));
lpThisValue->ForceSetValue(info.This());
std::unique_ptr<CFXJSE_Value> lpRetValue(new CFXJSE_Value(info.GetIsolate()));
- CFXJSE_ArgumentsImpl impl = {&info, lpRetValue.get()};
- lpClass->dynMethodCall(lpThisValue.get(), szFxPropName,
- reinterpret_cast<CFXJSE_Arguments&>(impl));
+ CFXJSE_Arguments impl(&info, lpRetValue.get());
+ lpClass->dynMethodCall(lpThisValue.get(), szFxPropName, impl);
if (!lpRetValue->DirectGetValue().IsEmpty()) {
info.GetReturnValue().Set(lpRetValue->DirectGetValue());
}
« no previous file with comments | « xfa/fxjse/class.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698