Correctly move permission bubbles after entering / exiting fullscreen.

chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h"
 
 #include <algorithm>
 
 #include "base/mac/bind_objc_block.h"
 #include "base/macros.h"
@@ skipping 284 matching lines @@
   [super windowWillClose:notification];
 }
 
 - (void)parentWindowWillToggleFullScreen:(NSNotification*)notification {
   // Override the base class implementation, which would have closed the bubble.
 }
 
 - (void)parentWindowDidResize:(NSNotification*)notification {
   DCHECK(bridge_);
   [self setAnchorPoint:[self getExpectedAnchorPoint]];
+  [[self bubble] setArrowLocation:[self getExpectedArrowLocation]];

[tapted, 2016/06/02 01:23:07]

I think this should be in - (void)updateAnchorPosition

and... parentWindowDidResize: should just call updateAnchorPosition?


(Also browser_window_controller_private.mm should _already_ be invoking
updateAnchorPosition on fullscreen transitions since it does


  // Will update the location of the permission bubble when showing/hiding the
  // top level toolbar in fullscreen.
  PermissionBubbleManager* manager = [self permissionBubbleManager];
  if (manager)
    manager->UpdateAnchorPosition();

That is, parentWindowDidResize: is probably completely unneeded, but there might
be something obscure, so I think it's fine to keep it for now, but just have it
call updateAnchorPosition)

[benwells, 2016/06/02 01:55:51]

Yeap ... I thought about all of that but wanted to keep the patch as minimal as
possible, and was worried about breaking things. I'll play with moving it around
and see what the impact is like.

[benwells, 2016/06/02 05:26:03]

Done.

 }
 
 - (void)parentWindowDidMove:(NSNotification*)notification {
   DCHECK(bridge_);
   [self setAnchorPoint:[self getExpectedAnchorPoint]];
 }
 
 - (void)showWithDelegate:(PermissionBubbleView::Delegate*)delegate
              forRequests:(const std::vector<PermissionBubbleRequest*>&)requests
             acceptStates:(const std::vector<bool>&)acceptStates {
@@ skipping 322 matching lines @@
 
 + (void)alignCenterOf:(NSView*)viewA verticallyToCenterOf:(NSView*)viewB {
   NSRect frameA = [viewA frame];
   NSRect frameB = [viewB frame];
   frameA.origin.y =
       NSMinY(frameB) + std::floor((NSHeight(frameB) - NSHeight(frameA)) / 2);
   [viewA setFrameOrigin:frameA.origin];
 }
 
 @end  // implementation PermissionBubbleController