Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2036483002: bluetooth: Add option dict to ReadValue/WriteValue dbus call (Closed)

Created:
4 years, 6 months ago by puthik_chromium
Modified:
4 years, 6 months ago
Reviewers:
rkc, ortuno, tinazh
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add option dict to ReadValue/WriteValue dbus call The BlueZ CL below added option dict to ReadValue and WriteValue. http://git.kernel.org/cgit/bluetooth/bluez.git/commit/?id=93b64d9 As we intend to use BlueZ API change for Gatt server funtionality, this CL updates Chrome DBus call to match the new BlueZ API by just append an empty option dict for Gatt client call. BUG=chromium:614903 TEST=Can read characteristic value from Pixel C keyboard Review-Url: https://codereview.chromium.org/2016023002 Cr-Commit-Position: refs/heads/master@{#396595} (cherry picked from commit 672ef3f9e8849b57eb03ef8752b861f410542ac7) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036483002/1
4 years, 6 months ago (2016-06-01 22:30:57 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-01 22:30:59 UTC) #4
puthik_chromium
For merge to M52
4 years, 6 months ago (2016-06-01 22:41:48 UTC) #6
ortuno
lgtm
4 years, 6 months ago (2016-06-01 22:43:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036483002/1
4 years, 6 months ago (2016-06-01 22:45:08 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 6 months ago (2016-06-01 22:45:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036483002/1
4 years, 6 months ago (2016-06-01 22:48:08 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 22:49:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698