Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc

Issue 2036483002: bluetooth: Add option dict to ReadValue/WriteValue dbus call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
diff --git a/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc b/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
index 0002ddbb03d0267a135a64cc41eedb81fe24e9d9..1ce7c35bc0f70af6978edb9e1e3148ebf5850835 100644
--- a/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
+++ b/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
@@ -10,8 +10,10 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
+#include "base/values.h"
#include "dbus/bus.h"
#include "dbus/object_manager.h"
+#include "dbus/values_util.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
namespace bluez {
@@ -95,6 +97,11 @@ class BluetoothGattCharacteristicClientImpl
bluetooth_gatt_characteristic::kBluetoothGattCharacteristicInterface,
bluetooth_gatt_characteristic::kReadValue);
+ // Append empty option dict
+ dbus::MessageWriter writer(&method_call);
+ base::DictionaryValue dict;
+ dbus::AppendValueData(&writer, dict);
+
object_proxy->CallMethodWithErrorCallback(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
base::Bind(&BluetoothGattCharacteristicClientImpl::OnValueSuccess,
@@ -121,6 +128,10 @@ class BluetoothGattCharacteristicClientImpl
dbus::MessageWriter writer(&method_call);
writer.AppendArrayOfBytes(value.data(), value.size());
+ // Append empty option dict
+ base::DictionaryValue dict;
+ dbus::AppendValueData(&writer, dict);
+
object_proxy->CallMethodWithErrorCallback(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
base::Bind(&BluetoothGattCharacteristicClientImpl::OnSuccess,
« no previous file with comments | « no previous file | device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698