Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2036443002: Modify status bubble text color. (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Modify status bubble text color. Change from 50% alpha to 60% alpha as starting point (as per sgabriel's recommendation). Add a second step where we calculate a readable color. This doesn't affect the classic theme but makes the text a little darker in some cases (like GTK mode). BUG=615175 Review-Url: https://codereview.chromium.org/2018023002 Cr-Commit-Position: refs/heads/master@{#396522} (cherry picked from commit 480bd209859e7848c6636638d4b4a6804bc6dc4f) Committed: https://chromium.googlesource.com/chromium/src/+/71494fd8723d7ed2f3414d09d7e0f52eaa9ae2dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/ui/views/status_bubble_views.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
4 years, 6 months ago (2016-06-01 21:53:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71494fd8723d7ed2f3414d09d7e0f52eaa9ae2dc.

Powered by Google App Engine
This is Rietveld 408576698