Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2018023002: Modify status bubble text color. (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify status bubble text color. Change from 50% alpha to 60% alpha as starting point (as per sgabriel's recommendation). Add a second step where we calculate a readable color. This doesn't affect the classic theme but makes the text a little darker in some cases (like GTK mode). BUG=615175 Committed: https://crrev.com/480bd209859e7848c6636638d4b4a6804bc6dc4f Cr-Commit-Position: refs/heads/master@{#396522}

Patch Set 1 #

Patch Set 2 : 60% #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/ui/views/status_bubble_views.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Evan Stade
4 years, 6 months ago (2016-05-27 16:52:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018023002/20001
4 years, 6 months ago (2016-05-27 17:06:36 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 18:23:53 UTC) #7
Peter Kasting
LGTM
4 years, 6 months ago (2016-05-27 18:38:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018023002/20001
4 years, 6 months ago (2016-05-27 18:41:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 18:46:37 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:48:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/480bd209859e7848c6636638d4b4a6804bc6dc4f
Cr-Commit-Position: refs/heads/master@{#396522}

Powered by Google App Engine
This is Rietveld 408576698