Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2036413003: Fix value_cleanup to handle cases where arg_expr is a macro. (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix value_cleanup to handle cases where arg_expr is a macro. Apparently true and false are macros! BUG=581865 R=danakj@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d5c75af8c710870b5a5f4067f17d72b50a21cd2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M tools/clang/value_cleanup/ListValueRewriter.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tools/clang/value_cleanup/tests/list-value-append-expected.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/clang/value_cleanup/tests/list-value-append-original.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dcheng
TIL.
4 years, 6 months ago (2016-06-03 21:06:10 UTC) #2
danakj
LGTM
4 years, 6 months ago (2016-06-03 21:08:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d5c75af8c710870b5a5f4067f17d72b50a21cd2f Cr-Commit-Position: refs/heads/master@{#397800}
4 years, 6 months ago (2016-06-03 21:13:17 UTC) #5
dcheng
4 years, 6 months ago (2016-06-03 21:15:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d5c75af8c710870b5a5f4067f17d72b50a21cd2f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698