Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: tools/clang/value_cleanup/ListValueRewriter.cpp

Issue 2036413003: Fix value_cleanup to handle cases where arg_expr is a macro. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/value_cleanup/tests/list-value-append-expected.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/value_cleanup/ListValueRewriter.cpp
diff --git a/tools/clang/value_cleanup/ListValueRewriter.cpp b/tools/clang/value_cleanup/ListValueRewriter.cpp
index d6c5cf233688e1de117bfc968c198708e6591e0a..ce27dd1f5b41368ddbf1ac5eb19955ae67d3bee2 100644
--- a/tools/clang/value_cleanup/ListValueRewriter.cpp
+++ b/tools/clang/value_cleanup/ListValueRewriter.cpp
@@ -32,8 +32,11 @@ void ListValueRewriter::AppendCallback::run(
auto* newExpr = result.Nodes.getNodeAs<clang::CXXNewExpr>("newExpr");
auto* argExpr = result.Nodes.getNodeAs<clang::Expr>("argExpr");
+ // Note that for the end loc, we use the expansion loc: the argument might be
+ // a macro like true and false.
clang::CharSourceRange pre_arg_range = clang::CharSourceRange::getCharRange(
- newExpr->getLocStart(), argExpr->getLocStart());
+ newExpr->getLocStart(),
+ result.SourceManager->getExpansionLoc(argExpr->getLocStart()));
replacements_->emplace(*result.SourceManager, pre_arg_range, "");
clang::CharSourceRange post_arg_range =
« no previous file with comments | « no previous file | tools/clang/value_cleanup/tests/list-value-append-expected.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698