third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebViewImpl.h ('K') | « third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index de41d3e91ce8ecd9b5bb46b2f2c9ee33fae80b21..0a6758d3f0c2d5e29755c430ad8546c204d21430 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -425,9 +425,10 @@ TEST_P(ParameterizedVisualViewportTest, TestWebViewResizedBeforeAttachment)

// Make sure that a resize that comes in while there's no root layer is

// honoured when we attach to the layer tree.

- webViewImpl()->setRootGraphicsLayer(nullptr);

+ WebFrameWidget* mainFrameWidget = static_cast<WebFrameWidget*>(webViewImpl()->mainFrame()->toWebLocalFrame()->frameWidget());

+ mainFrameWidget->setRootGraphicsLayer(nullptr);

webViewImpl()->resize(IntSize(320, 240));

- webViewImpl()->setRootGraphicsLayer(rootGraphicsLayer);

+ mainFrameWidget->setRootGraphicsLayer(rootGraphicsLayer);

navigateTo("about:blank");

webViewImpl()->updateAllLifecyclePhases();