Always use the WebFrameWidget when attaching the root graphics

third_party/WebKit/Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 407 matching lines @@
     LocalDOMWindow* pagePopupWindow() const;
 
     // Returns the input event we're currently processing. This is used in some
     // cases where the WebCore DOM event doesn't have the information we need.
     static const WebInputEvent* currentInputEvent()
     {
         return m_currentInputEvent;
     }
 
     GraphicsLayer* rootGraphicsLayer();
-    void setRootGraphicsLayer(GraphicsLayer*);
     PaintLayerCompositor* compositor() const;
     void scheduleAnimation();
-    void attachCompositorAnimationTimeline(CompositorAnimationTimeline*);
-    void detachCompositorAnimationTimeline(CompositorAnimationTimeline*);
     CompositorAnimationTimeline* linkHighlightsTimeline() const { return m_linkHighlightsTimeline.get(); }
 
     WebViewScheduler* scheduler() const override;
     void setVisibilityState(WebPageVisibilityState, bool) override;
 
     bool hasOpenedPopup() const { return m_pagePopup.get(); }
 
     // Returns true if the event leads to scrolling.
     static bool mapKeyCodeForScroll(
         int keyCode,
@@ skipping 92 matching lines @@
     float maximumLegiblePageScale() const;
     void refreshPageScaleFactorAfterLayout();
     IntSize contentsSize() const;
 
     void performResize();
     void resizeViewWhileAnchored(FrameView*, float topControlsHeight, bool topControlsShrinkLayout);
 
     friend class WebView;  // So WebView::Create can call our constructor
     friend class WTF::RefCounted<WebViewImpl>;
     friend void setCurrentInputEventForTest(const WebInputEvent*);
+    friend class WebViewFrameWidget;

[Mostyn Bramley-Moore, 2016/07/05 15:33:27]

This is a duplicate, after https://codereview.chromium.org/1991273003 landed in
the meantime.  Queued a fix: https://codereview.chromium.org/2121953003/

 
     enum DragAction {
       DragEnter,
       DragOver
     };
 
     explicit WebViewImpl(WebViewClient*);
     ~WebViewImpl() override;
 
     int textInputFlags();
@@ skipping 55 matching lines @@
     WebGestureEvent createGestureScrollEventFromFling(WebInputEvent::Type, WebGestureDevice) const;
 
     void enablePopupMouseWheelEventListener();
     void disablePopupMouseWheelEventListener();
 
     void cancelPagePopup();
     void updatePageOverlays();
 
     float deviceScaleFactor() const;
 
+    void setRootGraphicsLayer(GraphicsLayer*);
+    void attachCompositorAnimationTimeline(CompositorAnimationTimeline*);
+    void detachCompositorAnimationTimeline(CompositorAnimationTimeline*);
+
     WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)
     WebSpellCheckClient* m_spellCheckClient;
 
     Persistent<ChromeClientImpl> m_chromeClientImpl;
     ContextMenuClientImpl m_contextMenuClientImpl;
     EditorClientImpl m_editorClientImpl;
     SpellCheckerClientImpl m_spellCheckerClientImpl;
     StorageClientImpl m_storageClientImpl;
 
     WebSize m_size;
@@ skipping 129 matching lines @@
     double m_lastFrameTimeMonotonic;
 };
 
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 } // namespace blink
 
 #endif