components/printing/renderer/print_web_view_helper.cc - Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index fa79d1a2714353a0a665ff0e7f4c77d78738f0ea..53286f5ca69859f76f36a11f712d866ca2157d94 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -622,7 +622,7 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient,

const blink::WebString& unique_name,

blink::WebSandboxFlags sandbox_flags,

const blink::WebFrameOwnerProperties& frame_owner_properties) override;

- void frameDetached(blink::WebFrame* frame, DetachType type) override;

+ void frameDetached(blink::WebLocalFrame* frame, DetachType type) override;

void CallOnReady();

void ResizeForPrinting();

@@ -777,7 +777,7 @@ blink::WebFrame* PrepareFrameAndViewForPrint::createChildFrame(

return frame;

}

-void PrepareFrameAndViewForPrint::frameDetached(blink::WebFrame* frame,

+void PrepareFrameAndViewForPrint::frameDetached(blink::WebLocalFrame* frame,

DetachType type) {

DCHECK(type == DetachType::Remove);

if (frame->parent())

« no previous file with comments | « no previous file | content/renderer/render_frame_impl.h » ('j') | third_party/WebKit/Source/web/WebViewImpl.h » ('J')