tools/metrics/histograms/histograms.xml - Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/password_manager/core/browser/password_manager_metrics_util.h ('K') | « components/password_manager/core/common/password_manager_pref_names.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 3559c46947fc6345bab802393dd2e36b66a04c87..5ab8629adba5ba997f41f84256032479ce84b291 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -37400,6 +37400,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PasswordManager.SignInPromo"

+ enum="PasswordBubbleSignInPromoDismissalReason">

+ <owner>vasilii@chromium.org</owner>

+ <summary>

+ User action on the Chrome Sign in promo that appears in the password bubble.

Ilya Sherman 2016/06/03 21:21:25 It would be nice to go into a bit more detail on w

Ilya Sherman 2016/06/03 21:21:25 nit: Either "sign in" or "Sign In"

vasilii 2016/06/06 15:08:46 Done.

+ </summary>

+</histogram>

+<histogram name="PasswordManager.SignInPromoCountTilClick">

+ <owner>vasilii@chromium.org</owner>

+ <summary>

+ The number of times the Sign In promo in the password bubble was shown

+ before user clicked on it.

+ </summary>

+</histogram>

<histogram name="PasswordManager.StorePasswordImportedFromCSVResult"

enum="BooleanSuccess">

<owner>xunlu@chromium.org</owner>

@@ -82754,6 +82770,12 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

+<enum name="PasswordBubbleSignInPromoDismissalReason" type="int">

+ <int value="0" label="Dismissed"/>

+ <int value="1" label="Sign in"/>

+ <int value="2" label="No thanks"/>

+</enum>