components/password_manager/core/common/password_manager_pref_names.cc - Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/password_manager_pref_names.cc

Issue 2036323002: Implement the UI logic behind the Sign In promo in the password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager_metrics_util.h ('K') | « components/password_manager/core/common/password_manager_pref_names.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/password_manager_pref_names.cc

diff --git a/components/password_manager/core/common/password_manager_pref_names.cc b/components/password_manager/core/common/password_manager_pref_names.cc

index 8e65f41ccdf89814eb442bf479494419e92ef2e5..f06af87102fe5fa05a46067a9189c590fea7c9bc 100644

--- a/components/password_manager/core/common/password_manager_pref_names.cc

+++ b/components/password_manager/core/common/password_manager_pref_names.cc

@@ -33,5 +33,11 @@ const char kWasAutoSignInFirstRunExperienceShown[] =

const char kWasSavePrompFirstRunExperienceShown[] =

"profile.was_save_prompt_first_run_experience_shown";

+const char kWasSignInPasswordPromoClicked[] =

+ "profile.was_sign_in_password_promo_clicked";

+const char kNumberSignInPasswordPromoShown[] =

+ "profile.number_sign_in_password_promo_shown";

} // namespace prefs

} // namespace password_manager