Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2036313002: SkMipMap::ComputeLevelSize to return SkISize (Closed)

Created:
4 years, 6 months ago by cblume
Modified:
4 years, 6 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org, ericrk, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@pipe-mipmap-levels-to-creation
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkMipMap::ComputeLevelSize to return SkISize This previously returned SkSize, which had scalar components. That doesn't make sense for a mipmap size. R=bsalomon@google.com BUG=578304 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036313002 Committed: https://skia.googlesource.com/skia/+/44e09ec810e6d28df87caa3df61cf6fbfd806544

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M src/core/SkMipMap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMipMap.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/MipMapTest.cpp View 1 chunk +22 lines, -21 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036313002/1
4 years, 6 months ago (2016-06-03 17:01:25 UTC) #3
cblume
PTAL
4 years, 6 months ago (2016-06-03 17:01:46 UTC) #5
bsalomon
lgtm
4 years, 6 months ago (2016-06-03 17:12:16 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 17:16:55 UTC) #9
reed1
lgtm
4 years, 6 months ago (2016-06-03 17:18:08 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2031273002 Patch 40001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-03 17:36:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036313002/1
4 years, 6 months ago (2016-06-03 18:58:36 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:59:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/44e09ec810e6d28df87caa3df61cf6fbfd806544

Powered by Google App Engine
This is Rietveld 408576698