Plumbing mipmaps to the point of creation.

Plumbing mipmaps to the point of creation.

When creating a DeferredTextureImage we may create mipmaps.
Those mipmaps need to then be passed along for when the texture is
actually created.

R=bsalomon@google.com
BUG=578304
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2031273002

Committed: https://skia.googlesource.com/skia/+/186d2d430ba248fea1e00669154b95252ac9a486

[cblume, 2016-06-03 08:58:19]

Description was changed from

==========
Plumbing mipmaps to the point of creation.

When creating a DeferredTextureImage we may create mipmaps.
Those mipmaps need to then be passed along for when the texture is
actually created.

R=bsalomon@google.com
BUG=578304
==========

to

==========
Plumbing mipmaps to the point of creation.

When creating a DeferredTextureImage we may create mipmaps.
Those mipmaps need to then be passed along for when the texture is
actually created.

R=bsalomon@google.com
BUG=578304
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2031273002
==========

[cblume, 2016-06-03 08:58:35]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 08:58:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031273002/1

[cblume, 2016-06-03 08:59:10]

PTAL

[cblume, 2016-06-03 09:04:08]

https://codereview.chromium.org/2031273002/diff/1/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.chromium.org/2031273002/diff/1/src/gpu/SkGr.cpp#newcode399
src/gpu/SkGr.cpp:399: const GrCaps* caps = ctx->caps();
Should I be checking for sRGB here?
Like how GrUploadPixmapToTexture does?
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/s...

In fact, it looks like several pixel configs may need to be handled.

[cblume, 2016-06-03 09:12:30]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 09:12:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031273002/20001

[commit-bot: I haz the power, 2016-06-03 09:26:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 09:26:12]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-06-03 14:41:52]

https://codereview.chromium.org/2031273002/diff/20001/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/2031273002/diff/20001/include/core/SkImage.h#...
include/core/SkImage.h:146: static sk_sp<SkImage>
MakeTextureFromMipMap(GrContext*, const SkImageInfo&,
Do we need this in the public API? If it is only called internally from the
deferred texture data -> image factory function perhaps it could be private.

[reed1, 2016-06-03 15:59:47]

reed@google.com changed reviewers:
+ brianosman@google.com, reed@google.com

[reed1, 2016-06-03 15:59:47]

https://codereview.chromium.org/2031273002/diff/20001/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/2031273002/diff/20001/include/core/SkImage.h#...
include/core/SkImage.h:146: static sk_sp<SkImage>
MakeTextureFromMipMap(GrContext*, const SkImageInfo&,
On 2016/06/03 14:41:52, bsalomon wrote:
> Do we need this in the public API? If it is only called internally from the
> deferred texture data -> image factory function perhaps it could be private.

+1 to privatization.

BTW -- (other) Brian and I have changes in-flight where we can build more than
on mipmap for a given image, depending on the compatibility-mode we're in for
sRGB...

[cblume, 2016-06-03 16:21:57]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 16:22:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031273002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031273002/40001

[cblume, 2016-06-03 16:22:40]

https://codereview.chromium.org/2031273002/diff/20001/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/2031273002/diff/20001/include/core/SkImage.h#...
include/core/SkImage.h:146: static sk_sp<SkImage>
MakeTextureFromMipMap(GrContext*, const SkImageInfo&,
On 2016/06/03 15:59:47, reed1 wrote:
> On 2016/06/03 14:41:52, bsalomon wrote:
> > Do we need this in the public API? If it is only called internally from the
> > deferred texture data -> image factory function perhaps it could be private.
> 
> +1 to privatization.
> 
> BTW -- (other) Brian and I have changes in-flight where we can build more than
> on mipmap for a given image, depending on the compatibility-mode we're in for
> sRGB...

Done.

[bsalomon, 2016-06-03 16:30:57]

lgtm

[commit-bot: I haz the power, 2016-06-03 16:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 16:49:11]

Dry run: This issue passed the CQ dry run.

[cblume, 2016-06-03 18:16:38]

The CQ bit was checked by cblume@chromium.org

[commit-bot: I haz the power, 2016-06-03 18:16:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031273002/40001

[commit-bot: I haz the power, 2016-06-03 18:17:44]

Description was changed from

==========
Plumbing mipmaps to the point of creation.

When creating a DeferredTextureImage we may create mipmaps.
Those mipmaps need to then be passed along for when the texture is
actually created.

R=bsalomon@google.com
BUG=578304
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2031273002
==========

to

==========
Plumbing mipmaps to the point of creation.

When creating a DeferredTextureImage we may create mipmaps.
Those mipmaps need to then be passed along for when the texture is
actually created.

R=bsalomon@google.com
BUG=578304
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2031273002

Committed:
https://skia.googlesource.com/skia/+/186d2d430ba248fea1e00669154b95252ac9a486
==========

[commit-bot: I haz the power, 2016-06-03 18:17:45]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/186d2d430ba248fea1e00669154b95252ac9a486