Fix some code which causes warnings when compiled by /analyze tool

Fix some code which causes warnings when compiled by /analyze tool

The code may not cause error conditions, but can be improved. These
warnings include uninitialized variables, signed/unsigned mismatch,
redundant condition, and using bool in arithmetic operations. 
Also remove a chunk of unused code.

BUG=chromium:613623, chromium:427616
Committed: https://pdfium.googlesource.com/pdfium/+/12367cb5e83e771cd67948c810fdd5f63d61af87

[Wei Li, 2016-06-03 17:24:49]

Description was changed from

==========
Fix some code which causes warnings when compiled by /analyze tool

The code may not cause error conditions, but can be improved. These
warnings include uninitialized variables, signed/unsigned mismatch,
and using bool in arithmetic operations. Also remove a chunk of
unused code.

BUG=chromium:613623, chromium:427616
==========

to

==========
Fix some code which causes warnings when compiled by /analyze tool

The code may not cause error conditions, but can be improved. These
warnings include uninitialized variables, signed/unsigned mismatch,
redundant condition, and using bool in arithmetic operations. 
Also remove a chunk of unused code.

BUG=chromium:613623, chromium:427616
==========

[Wei Li, 2016-06-03 17:52:12]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-06-03 18:08:00]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[Wei Li, 2016-06-03 18:08:00]

pls review, thanks

[Tom Sepez, 2016-06-03 18:11:46]

lgtm

https://codereview.chromium.org/2036203004/diff/20001/core/fxcodec/jbig2/JBig...
File core/fxcodec/jbig2/JBig2_Context.cpp (right):

https://codereview.chromium.org/2036203004/diff/20001/core/fxcodec/jbig2/JBig...
core/fxcodec/jbig2/JBig2_Context.cpp:634: if (m_bIsGlobal) {
This probably wanted to be an ifdef to remove this code if the cache was 0.  No
matter.

[Wei Li, 2016-06-03 18:21:53]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-06-03 18:21:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036203004/20001

[commit-bot: I haz the power, 2016-06-03 18:22:19]

Description was changed from

==========
Fix some code which causes warnings when compiled by /analyze tool

The code may not cause error conditions, but can be improved. These
warnings include uninitialized variables, signed/unsigned mismatch,
redundant condition, and using bool in arithmetic operations. 
Also remove a chunk of unused code.

BUG=chromium:613623, chromium:427616
==========

to

==========
Fix some code which causes warnings when compiled by /analyze tool

The code may not cause error conditions, but can be improved. These
warnings include uninitialized variables, signed/unsigned mismatch,
redundant condition, and using bool in arithmetic operations. 
Also remove a chunk of unused code.

BUG=chromium:613623, chromium:427616

Committed:
https://pdfium.googlesource.com/pdfium/+/12367cb5e83e771cd67948c810fdd5f63d61...
==========

[commit-bot: I haz the power, 2016-06-03 18:22:20]

Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/12367cb5e83e771cd67948c810fdd5f63d61...