Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2036203004: Fix some code which causes warnings when compiled by /analyze tool (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix some code which causes warnings when compiled by /analyze tool The code may not cause error conditions, but can be improved. These warnings include uninitialized variables, signed/unsigned mismatch, redundant condition, and using bool in arithmetic operations. Also remove a chunk of unused code. BUG=chromium:613623, chromium:427616 Committed: https://pdfium.googlesource.com/pdfium/+/12367cb5e83e771cd67948c810fdd5f63d61af87

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -113 lines) Patch
M core/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_decode_unittest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxcodec/codec/fx_codec.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
M core/fxcodec/codec/fx_codec_png.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.cpp View 1 chunk +1 line, -1 line 1 comment Download
M fpdfsdk/fpdf_flatten.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/fsdk_baseannot.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Wei Li
pls review, thanks
4 years, 6 months ago (2016-06-03 18:08:00 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/2036203004/diff/20001/core/fxcodec/jbig2/JBig2_Context.cpp File core/fxcodec/jbig2/JBig2_Context.cpp (right): https://codereview.chromium.org/2036203004/diff/20001/core/fxcodec/jbig2/JBig2_Context.cpp#newcode634 core/fxcodec/jbig2/JBig2_Context.cpp:634: if (m_bIsGlobal) { This probably wanted to be ...
4 years, 6 months ago (2016-06-03 18:11:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036203004/20001
4 years, 6 months ago (2016-06-03 18:21:59 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:22:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/12367cb5e83e771cd67948c810fdd5f63d61...

Powered by Google App Engine
This is Rietveld 408576698