core/fxcodec/jbig2/JBig2_Context.cpp - Issue 2036203004: Fix some code which causes warnings when compiled by /analyze tool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/jbig2/JBig2_Context.cpp

Issue 2036203004: Fix some code which causes warnings when compiled by /analyze tool (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxcodec/jbig2/JBig2_Context.cpp

diff --git a/core/fxcodec/jbig2/JBig2_Context.cpp b/core/fxcodec/jbig2/JBig2_Context.cpp

index a0a411fbcfd17d3c82674c76808de8ed46debec8..25c9ff76494075dd43801dcc2fdc455115cea6af 100644

--- a/core/fxcodec/jbig2/JBig2_Context.cpp

+++ b/core/fxcodec/jbig2/JBig2_Context.cpp

@@ -631,7 +631,7 @@ int32_t CJBig2_Context::parseSymbolDict(CJBig2_Segment* pSegment,

return JBIG2_ERROR_FATAL;

m_pStream->alignByte();

}

- if (m_bIsGlobal && kSymbolDictCacheMaxSize > 0) {

+ if (m_bIsGlobal) {

Tom Sepez 2016/06/03 18:11:46 This probably wanted to be an ifdef to remove this

std::unique_ptr<CJBig2_SymbolDict> value =

pSegment->m_Result.sd->DeepCopy();

int size = pdfium::CollectionSize<int>(*m_pSymbolDictCache);

« no previous file with comments | « core/fxcodec/codec/fx_codec_png.cpp ('k') | fpdfsdk/fpdf_flatten.cpp » ('j') | no next file with comments »