LayoutTests/fast/js/function-length.html - Issue 203603005: Explicitly mark first 2 args of addEventListener/removeEventListener as optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/js/function-length.html

Issue 203603005: Explicitly mark first 2 args of addEventListener/removeEventListener as optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update test result (addEventListener.length now 0, not 2) Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/js/function-length.html

diff --git a/LayoutTests/fast/js/function-length.html b/LayoutTests/fast/js/function-length.html

index b758f6e46b5194b7e2aee80211f21d0ff7dc984f..897f1a4bc85a1d365ad0c877f555fcdd45523f3c 100644

--- a/LayoutTests/fast/js/function-length.html

+++ b/LayoutTests/fast/js/function-length.html

@@ -12,7 +12,9 @@ shouldBe('window.open.length', '2');

shouldBe('window.showModalDialog.length', '1');

shouldBe('window.setTimeout.length', '1');

shouldBe('window.clearTimeout.length', '0');

-shouldBe('window.addEventListener.length', '2');

+// addEventListener.length should be 2, but legacy content calls with 0 or 1

+// argument. See http://crbug.com/249598

+shouldBe('window.addEventListener.length', '0');

shouldBe('window.postMessage.length', '2');

shouldBe('window.dispatchEvent.length', '1');

shouldBe('window.openDatabase.length', '4');

« no previous file with comments | « LayoutTests/fast/dom/event-target-arguments-expected.txt ('k') | LayoutTests/fast/js/function-length-expected.txt » ('j') | no next file with comments »