LayoutTests/fast/js/function-length.html - Issue 203603005: Explicitly mark first 2 args of addEventListener/removeEventListener as optional

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/js/function-length.html

Issue 203603005: Explicitly mark first 2 args of addEventListener/removeEventListener as optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update test result (addEventListener.length now 0, not 2) Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("This tests the length property of functions.");	8 description("This tests the length property of functions.");

9	9

10 shouldBe('window.confirm.length', '0');	10 shouldBe('window.confirm.length', '0');

11 shouldBe('window.open.length', '2');	11 shouldBe('window.open.length', '2');

12 shouldBe('window.showModalDialog.length', '1');	12 shouldBe('window.showModalDialog.length', '1');

13 shouldBe('window.setTimeout.length', '1');	13 shouldBe('window.setTimeout.length', '1');

14 shouldBe('window.clearTimeout.length', '0');	14 shouldBe('window.clearTimeout.length', '0');

15 shouldBe('window.addEventListener.length', '2');	15 // addEventListener.length should be 2, but legacy content calls with 0 or 1

	16 // argument. See http://crbug.com/249598

	17 shouldBe('window.addEventListener.length', '0');

16 shouldBe('window.postMessage.length', '2');	18 shouldBe('window.postMessage.length', '2');

17 shouldBe('window.dispatchEvent.length', '1');	19 shouldBe('window.dispatchEvent.length', '1');

18 shouldBe('window.openDatabase.length', '4');	20 shouldBe('window.openDatabase.length', '4');

19 shouldBe('window.history.pushState.length', '2');	21 shouldBe('window.history.pushState.length', '2');

20 shouldBe('window.history.length', '1');	22 shouldBe('window.history.length', '1');

21 shouldBe('window.URL.createObjectURL.length', '1');	23 shouldBe('window.URL.createObjectURL.length', '1');

22 shouldBe('window.Storage.prototype.key.length', '1');	24 shouldBe('window.Storage.prototype.key.length', '1');

23	25

24 shouldBe('Array.prototype.concat.length', '1');	26 shouldBe('Array.prototype.concat.length', '1');

25 shouldBe('Array.prototype.join.length', '1');	27 shouldBe('Array.prototype.join.length', '1');

(...skipping 12 matching lines...) Expand all Loading...
38 shouldBe('Math.min.length', '2');	40 shouldBe('Math.min.length', '2');

39 shouldBe('Function.prototype.apply.length', '2');	41 shouldBe('Function.prototype.apply.length', '2');

40 shouldBe('Function.prototype.call.length', '1');	42 shouldBe('Function.prototype.call.length', '1');

41 shouldBe('String.prototype.split.length', '2');	43 shouldBe('String.prototype.split.length', '2');

42 shouldBe('String.prototype.substring.length', '2');	44 shouldBe('String.prototype.substring.length', '2');

43	45

44	46

45 </script>	47 </script>

46 </body>	48 </body>

47 </html>	49 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/dom/event-target-arguments-expected.txt ('k') | LayoutTests/fast/js/function-length-expected.txt » ('j') | no next file with comments »