android_webview/native/aw_contents.h - Issue 2036023002: Rewire Android WebView's compositor changed signal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.h

Issue 2036023002: Rewire Android WebView's compositor changed signal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix browse_view_renderer construction and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/render_thread_manager.h ('K') | « android_webview/browser/render_thread_manager.cc ('k') | android_webview/native/aw_contents.cc » ('j') | content/browser/android/synchronous_compositor_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.h

diff --git a/android_webview/native/aw_contents.h b/android_webview/native/aw_contents.h

index 5062eb88ea5f34f303be2608d210a26ae8def30f..638aed53fc89c660c28966f73748839139426f0b 100644

--- a/android_webview/native/aw_contents.h

+++ b/android_webview/native/aw_contents.h

@@ -346,10 +346,10 @@ class AwContents : public FindHelper::Listener,

JavaObjectWeakGlobalRef java_ref_;

AwGLFunctor* functor_;

+ std::unique_ptr<content::WebContents> web_contents_;

BrowserViewRenderer browser_view_renderer_; // Must outlive |web_contents_|.

boliu 2016/06/13 15:30:44 uhh... the comment is clearly wrong now maybe sho

hush (inactive) 2016/06/14 23:48:29 I put it back to place. It was added so that Synch

std::unique_ptr<AwWebContentsDelegate> web_contents_delegate_;

std::unique_ptr<AwContentsClientBridge> contents_client_bridge_;

- std::unique_ptr<content::WebContents> web_contents_;

std::unique_ptr<AwRenderViewHostExt> render_view_host_ext_;

std::unique_ptr<FindHelper> find_helper_;

std::unique_ptr<IconHelper> icon_helper_;