android_webview/native/aw_contents.cc - Issue 2036023002: Rewire Android WebView's compositor changed signal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.cc

Issue 2036023002: Rewire Android WebView's compositor changed signal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix browse_view_renderer construction and rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_contents.h ('K') | « android_webview/native/aw_contents.h ('k') | content/browser/android/synchronous_compositor_host.h » ('j') | content/browser/android/synchronous_compositor_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.cc

diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc

index 44738a3edbbff8e4e28ff62fd1072092703f96e1..1c856da411a51b77f90d92ac170c61fb2705eab9 100644

--- a/android_webview/native/aw_contents.cc

+++ b/android_webview/native/aw_contents.cc

@@ -173,10 +173,11 @@ AwBrowserPermissionRequestDelegate* AwBrowserPermissionRequestDelegate::FromID(

AwContents::AwContents(std::unique_ptr<WebContents> web_contents)

: functor_(nullptr),

+ web_contents_(std::move(web_contents)),

browser_view_renderer_(

+ web_contents_.get(),

this,

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI)),

- web_contents_(std::move(web_contents)),

renderer_manager_key_(GLViewRendererManager::GetInstance()->NullKey()) {

base::subtle::NoBarrier_AtomicIncrement(&g_instance_count, 1);

icon_helper_.reset(new IconHelper(web_contents_.get()));