Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2036003002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //ipc (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //ipc The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/3e86de2ad8d6e9159cf630570b90b079ef1aa64a Cr-Commit-Position: refs/heads/master@{#397622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ipc/ipc_message_utils_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dcheng
4 years, 6 months ago (2016-06-02 22:22:32 UTC) #2
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-02 22:23:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036003002/1
4 years, 6 months ago (2016-06-02 22:24:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/81172)
4 years, 6 months ago (2016-06-02 23:14:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036003002/1
4 years, 6 months ago (2016-06-03 03:21:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 04:03:21 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 04:05:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e86de2ad8d6e9159cf630570b90b079ef1aa64a
Cr-Commit-Position: refs/heads/master@{#397622}

Powered by Google App Engine
This is Rietveld 408576698