Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: ipc/ipc_message_utils_unittest.cc

Issue 2036003002: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //ipc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_utils_unittest.cc
diff --git a/ipc/ipc_message_utils_unittest.cc b/ipc/ipc_message_utils_unittest.cc
index 51e8336a010d4dd1a01df3dbe42107d7e538cfc0..977c9e0606f4f1cba59394f3fad522b9242612f4 100644
--- a/ipc/ipc_message_utils_unittest.cc
+++ b/ipc/ipc_message_utils_unittest.cc
@@ -105,8 +105,8 @@ TEST(IPCMessageUtilsTest, ValueSize) {
value->SetWithoutPathExpansion("nested", std::move(nested_dict));
std::unique_ptr<base::ListValue> list_value(new base::ListValue);
- list_value->Append(new base::StringValue("im a string"));
- list_value->Append(new base::StringValue("im another string"));
+ list_value->AppendString("im a string");
+ list_value->AppendString("im another string");
value->SetWithoutPathExpansion("awesome-list", std::move(list_value));
base::Pickle pickle;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698