Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2035893002: [Sync] Fix minor credit card sync UI glitch on Android. (Closed)

Created:
4 years, 6 months ago by maxbogue
Modified:
4 years, 6 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix minor credit card sync UI glitch on Android. BUG=615519 Committed: https://crrev.com/9f5a57718c29e994c5b2e707a196b904ccf6f365 Cr-Commit-Position: refs/heads/master@{#397579}

Patch Set 1 #

Patch Set 2 : Add a regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
maxbogue
Pavel, PTAL!
4 years, 6 months ago (2016-06-02 22:57:27 UTC) #2
pavely
lgtm
4 years, 6 months ago (2016-06-02 23:15:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035893002/20001
4 years, 6 months ago (2016-06-02 23:22:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 02:25:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:28:07 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9f5a57718c29e994c5b2e707a196b904ccf6f365
Cr-Commit-Position: refs/heads/master@{#397579}

Powered by Google App Engine
This is Rietveld 408576698