chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java - Issue 2035893002: [Sync] Fix minor credit card sync UI glitch on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java

Issue 2035893002: [Sync] Fix minor credit card sync UI glitch on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a regression test. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java

index 6f0b789fcc87c1802cb7a1a1b1533b25d66a73c8..661ed263f28eb73b0f4ca9040d48ef8c8167f880 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java

@@ -567,7 +567,9 @@ public class SyncCustomizationFragment extends PreferenceFragment

for (CheckBoxPreference pref : mAllTypes) {

boolean canSyncType = true;

if (pref == mSyncPasswords) canSyncType = passwordSyncConfigurable;

- if (pref == mPaymentsIntegration) canSyncType = syncAutofill;

+ if (pref == mPaymentsIntegration) {

+ canSyncType = syncAutofill || syncEverything;

+ }

if (!isSyncEnabled) {

pref.setChecked(true);