Add support for finding/creating general GrVkRenderPass from the VkResourceProvider.

Add support for finding/creating general GrVkRenderPass from the VkResourceProvider.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035853002

Committed: https://skia.googlesource.com/skia/+/2feb0938dcf223da3641daf15f5d525db88a6967

[egdaniel, 2016-06-02 17:35:23]

Description was changed from

==========
Add support for finding/creating general GrVkRenderPass from the
VkResourceProvider.

BUG=skia:
==========

to

==========
Add support for finding/creating general GrVkRenderPass from the
VkResourceProvider.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035853002
==========

[egdaniel, 2016-06-02 18:16:46]

egdaniel@google.com changed reviewers:
+ brianosman@google.com, jvanverth@google.com

[egdaniel, 2016-06-02 18:16:47]

This CL follows: https://codereview.chromium.org/1977403002/

[jvanverth1, 2016-06-02 21:26:48]

A couple of starting comments. I'll take another look tomorrow.

https://codereview.chromium.org/2035853002/diff/1/src/gpu/vk/GrVkRenderPass.cpp
File src/gpu/vk/GrVkRenderPass.cpp (right):

https://codereview.chromium.org/2035853002/diff/1/src/gpu/vk/GrVkRenderPass.c...
src/gpu/vk/GrVkRenderPass.cpp:18: const GrVkRenderPass::LoadStoreOps
GrVkRenderPass::kBasicLoadStoreOps;
I think you might need to put this inside of GrVkRenderPass::initSimple() to get
around Chrome's "no static variables" fiat.

https://codereview.chromium.org/2035853002/diff/1/src/gpu/vk/GrVkRenderPass.h
File src/gpu/vk/GrVkRenderPass.h (right):

https://codereview.chromium.org/2035853002/diff/1/src/gpu/vk/GrVkRenderPass.h...
src/gpu/vk/GrVkRenderPass.h:30: : fLoadOp(VK_ATTACHMENT_LOAD_OP_LOAD)
This means any time you create any of these structs without the explicit
initializer, it'll call this, whether you want it or not (e.g., you might
overwrite it with other data immediately). In the constructor for AttachmentDesc
you could use the explicit fLoadStoreOps(VK_ATTACHMENT_LOAD_OP_LOAD,
VK_ATTACHMENT_STORE_OP_STORE) instead.

[egdaniel, 2016-06-06 14:14:58]

https://codereview.chromium.org/2035853002/diff/1/src/gpu/vk/GrVkRenderPass.cpp
File src/gpu/vk/GrVkRenderPass.cpp (right):

https://codereview.chromium.org/2035853002/diff/1/src/gpu/vk/GrVkRenderPass.c...
src/gpu/vk/GrVkRenderPass.cpp:18: const GrVkRenderPass::LoadStoreOps
GrVkRenderPass::kBasicLoadStoreOps;
On 2016/06/02 21:26:48, jvanverth1 wrote:
> I think you might need to put this inside of GrVkRenderPass::initSimple() to
get
> around Chrome's "no static variables" fiat.

Done.

https://codereview.chromium.org/2035853002/diff/1/src/gpu/vk/GrVkRenderPass.h
File src/gpu/vk/GrVkRenderPass.h (right):

https://codereview.chromium.org/2035853002/diff/1/src/gpu/vk/GrVkRenderPass.h...
src/gpu/vk/GrVkRenderPass.h:30: : fLoadOp(VK_ATTACHMENT_LOAD_OP_LOAD)
On 2016/06/02 21:26:48, jvanverth1 wrote:
> This means any time you create any of these structs without the explicit
> initializer, it'll call this, whether you want it or not (e.g., you might
> overwrite it with other data immediately). In the constructor for
AttachmentDesc
> you could use the explicit fLoadStoreOps(VK_ATTACHMENT_LOAD_OP_LOAD,
> VK_ATTACHMENT_STORE_OP_STORE) instead.

Done.

[egdaniel, 2016-06-07 15:22:57]

ping

[jvanverth1, 2016-06-07 19:11:56]

lgtm

[egdaniel, 2016-06-08 13:35:04]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-06-08 13:35:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035853002/40001

[commit-bot: I haz the power, 2016-06-08 13:48:13]

Description was changed from

==========
Add support for finding/creating general GrVkRenderPass from the
VkResourceProvider.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035853002
==========

to

==========
Add support for finding/creating general GrVkRenderPass from the
VkResourceProvider.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2035853002

Committed:
https://skia.googlesource.com/skia/+/2feb0938dcf223da3641daf15f5d525db88a6967
==========

[commit-bot: I haz the power, 2016-06-08 13:48:14]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2feb0938dcf223da3641daf15f5d525db88a6967