Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2035743002: Remove unused context param from execute. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused context param from execute. The IJS_Context parameter is never used, removed. Committed: https://pdfium.googlesource.com/pdfium/+/884b4f942d510974e713361b84a717340eb928b9

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M fpdfsdk/javascript/JS_Runtime_Stub.cpp View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/ijs_runtime.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/jsapi/fxjs_v8.cpp View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/jsapi/include/fxjs_v8.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (3 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-02 14:30:07 UTC) #2
Tom Sepez
https://codereview.chromium.org/2035743002/diff/20001/fpdfsdk/jsapi/fxjs_v8.cpp File fpdfsdk/jsapi/fxjs_v8.cpp (right): https://codereview.chromium.org/2035743002/diff/20001/fpdfsdk/jsapi/fxjs_v8.cpp#newcode427 fpdfsdk/jsapi/fxjs_v8.cpp:427: CFX_ByteString bsScript = CFX_WideString(script).UTF8Encode(); this started out as a ...
4 years, 6 months ago (2016-06-02 18:25:36 UTC) #3
dsinclair
https://codereview.chromium.org/2035743002/diff/20001/fpdfsdk/jsapi/fxjs_v8.cpp File fpdfsdk/jsapi/fxjs_v8.cpp (right): https://codereview.chromium.org/2035743002/diff/20001/fpdfsdk/jsapi/fxjs_v8.cpp#newcode427 fpdfsdk/jsapi/fxjs_v8.cpp:427: CFX_ByteString bsScript = CFX_WideString(script).UTF8Encode(); On 2016/06/02 18:25:35, Tom Sepez ...
4 years, 6 months ago (2016-06-02 18:57:45 UTC) #4
Tom Sepez
Several other places. https://codereview.chromium.org/2035743002/diff/40001/fpdfsdk/javascript/JS_Runtime_Stub.cpp File fpdfsdk/javascript/JS_Runtime_Stub.cpp (right): https://codereview.chromium.org/2035743002/diff/40001/fpdfsdk/javascript/JS_Runtime_Stub.cpp#newcode151 fpdfsdk/javascript/JS_Runtime_Stub.cpp:151: int Execute(const CFX_WideString script, CFX_WideString* info) ...
4 years, 6 months ago (2016-06-02 20:39:31 UTC) #5
dsinclair
PTAL. https://codereview.chromium.org/2035743002/diff/40001/fpdfsdk/javascript/JS_Runtime_Stub.cpp File fpdfsdk/javascript/JS_Runtime_Stub.cpp (right): https://codereview.chromium.org/2035743002/diff/40001/fpdfsdk/javascript/JS_Runtime_Stub.cpp#newcode151 fpdfsdk/javascript/JS_Runtime_Stub.cpp:151: int Execute(const CFX_WideString script, CFX_WideString* info) override { ...
4 years, 6 months ago (2016-06-06 12:56:17 UTC) #6
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-06 16:45:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035743002/60001
4 years, 6 months ago (2016-06-06 16:49:16 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 16:49:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/884b4f942d510974e713361b84a717340eb9...

Powered by Google App Engine
This is Rietveld 408576698