Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp

Issue 2035743002: Remove unused context param from execute. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/jsapi/fxjs_v8.cpp ('k') | fpdfsdk/jsapi/include/fxjs_v8.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 PDFium Authors. All rights reserved. 1 // Copyright 2015 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "testing/gtest/include/gtest/gtest.h" 5 #include "testing/gtest/include/gtest/gtest.h"
6 #include "testing/js_embedder_test.h" 6 #include "testing/js_embedder_test.h"
7 7
8 namespace { 8 namespace {
9 9
10 const double kExpected0 = 6.0; 10 const double kExpected0 = 6.0;
11 const double kExpected1 = 7.0; 11 const double kExpected1 = 7.0;
12 const double kExpected2 = 8.0; 12 const double kExpected2 = 8.0;
13 13
14 const wchar_t kScript0[] = L"fred = 6"; 14 const wchar_t kScript0[] = L"fred = 6";
15 const wchar_t kScript1[] = L"fred = 7"; 15 const wchar_t kScript1[] = L"fred = 7";
16 const wchar_t kScript2[] = L"fred = 8"; 16 const wchar_t kScript2[] = L"fred = 8";
17 17
18 } // namespace 18 } // namespace
19 19
20 class FXJSV8EmbedderTest : public JSEmbedderTest { 20 class FXJSV8EmbedderTest : public JSEmbedderTest {
21 public: 21 public:
22 void ExecuteInCurrentContext(const wchar_t* script) { 22 void ExecuteInCurrentContext(const CFX_WideString& script) {
23 FXJSErr error; 23 FXJSErr error;
24 int sts = FXJS_Execute(isolate(), nullptr, script, &error); 24 int sts = FXJS_Execute(isolate(), script, &error);
25 EXPECT_EQ(0, sts); 25 EXPECT_EQ(0, sts);
26 } 26 }
27 void CheckAssignmentInCurrentContext(double expected) { 27 void CheckAssignmentInCurrentContext(double expected) {
28 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate()); 28 v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());
29 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred"); 29 v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred");
30 EXPECT_TRUE(fred->IsNumber()); 30 EXPECT_TRUE(fred->IsNumber());
31 EXPECT_EQ(expected, fred->ToNumber(isolate()->GetCurrentContext()) 31 EXPECT_EQ(expected, fred->ToNumber(isolate()->GetCurrentContext())
32 .ToLocalChecked() 32 .ToLocalChecked()
33 ->Value()); 33 ->Value());
34 } 34 }
35 }; 35 };
36 36
37 TEST_F(FXJSV8EmbedderTest, Getters) { 37 TEST_F(FXJSV8EmbedderTest, Getters) {
38 v8::Isolate::Scope isolate_scope(isolate()); 38 v8::Isolate::Scope isolate_scope(isolate());
39 v8::HandleScope handle_scope(isolate()); 39 v8::HandleScope handle_scope(isolate());
40 v8::Context::Scope context_scope(GetV8Context()); 40 v8::Context::Scope context_scope(GetV8Context());
41 41
42 ExecuteInCurrentContext(kScript1); 42 ExecuteInCurrentContext(CFX_WideString(kScript1));
43 CheckAssignmentInCurrentContext(kExpected1); 43 CheckAssignmentInCurrentContext(kExpected1);
44 } 44 }
45 45
46 TEST_F(FXJSV8EmbedderTest, MultipleRutimes) { 46 TEST_F(FXJSV8EmbedderTest, MultipleRutimes) {
47 v8::Isolate::Scope isolate_scope(isolate()); 47 v8::Isolate::Scope isolate_scope(isolate());
48 v8::HandleScope handle_scope(isolate()); 48 v8::HandleScope handle_scope(isolate());
49 49
50 v8::Global<v8::Context> global_context1; 50 v8::Global<v8::Context> global_context1;
51 std::vector<v8::Global<v8::Object>*> static_objects1; 51 std::vector<v8::Global<v8::Object>*> static_objects1;
52 FXJS_InitializeRuntime(isolate(), nullptr, &global_context1, 52 FXJS_InitializeRuntime(isolate(), nullptr, &global_context1,
53 &static_objects1); 53 &static_objects1);
54 54
55 v8::Global<v8::Context> global_context2; 55 v8::Global<v8::Context> global_context2;
56 std::vector<v8::Global<v8::Object>*> static_objects2; 56 std::vector<v8::Global<v8::Object>*> static_objects2;
57 FXJS_InitializeRuntime(isolate(), nullptr, &global_context2, 57 FXJS_InitializeRuntime(isolate(), nullptr, &global_context2,
58 &static_objects2); 58 &static_objects2);
59 59
60 v8::Context::Scope context_scope(GetV8Context()); 60 v8::Context::Scope context_scope(GetV8Context());
61 ExecuteInCurrentContext(kScript0); 61 ExecuteInCurrentContext(CFX_WideString(kScript0));
62 CheckAssignmentInCurrentContext(kExpected0); 62 CheckAssignmentInCurrentContext(kExpected0);
63 63
64 { 64 {
65 v8::Local<v8::Context> context1 = 65 v8::Local<v8::Context> context1 =
66 v8::Local<v8::Context>::New(isolate(), global_context1); 66 v8::Local<v8::Context>::New(isolate(), global_context1);
67 v8::Context::Scope context_scope1(context1); 67 v8::Context::Scope context_scope1(context1);
68 ExecuteInCurrentContext(kScript1); 68 ExecuteInCurrentContext(CFX_WideString(kScript1));
69 CheckAssignmentInCurrentContext(kExpected1); 69 CheckAssignmentInCurrentContext(kExpected1);
70 } 70 }
71 FXJS_ReleaseRuntime(isolate(), &global_context1, &static_objects1); 71 FXJS_ReleaseRuntime(isolate(), &global_context1, &static_objects1);
72 72
73 { 73 {
74 v8::Local<v8::Context> context2 = 74 v8::Local<v8::Context> context2 =
75 v8::Local<v8::Context>::New(isolate(), global_context2); 75 v8::Local<v8::Context>::New(isolate(), global_context2);
76 v8::Context::Scope context_scope2(context2); 76 v8::Context::Scope context_scope2(context2);
77 ExecuteInCurrentContext(kScript2); 77 ExecuteInCurrentContext(CFX_WideString(kScript2));
78 CheckAssignmentInCurrentContext(kExpected2); 78 CheckAssignmentInCurrentContext(kExpected2);
79 } 79 }
80 FXJS_ReleaseRuntime(isolate(), &global_context2, &static_objects2); 80 FXJS_ReleaseRuntime(isolate(), &global_context2, &static_objects2);
81 81
82 CheckAssignmentInCurrentContext(kExpected0); 82 CheckAssignmentInCurrentContext(kExpected0);
83 } 83 }
OLDNEW
« no previous file with comments | « fpdfsdk/jsapi/fxjs_v8.cpp ('k') | fpdfsdk/jsapi/include/fxjs_v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698