Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 2035683002: [turbofan] Fix assert caused by bogus merging of out-of-scope CodeAssembler variables (Closed)

Created:
4 years, 6 months ago by danno
Modified:
4 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, epertoso
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix assert caused by bogus merging of out-of-scope CodeAssembler variables Previously, CodeAssembler Variables declared in an explicit C++ scope would continue to be merged into future labels beyond that scope, causing asserts. This CL ensures that Variables are properly ignored when they go out of scope. Committed: https://crrev.com/70e302eeddfe8b078b257975b0ad7b9748974f00 Cr-Commit-Position: refs/heads/master@{#36690}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M src/compiler/code-assembler.h View 3 chunks +3 lines, -1 line 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
danno
PTAL
4 years, 6 months ago (2016-06-02 13:06:33 UTC) #2
Michael Starzinger
LGTM.
4 years, 6 months ago (2016-06-02 14:46:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035683002/1
4 years, 6 months ago (2016-06-02 15:15:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16392)
4 years, 6 months ago (2016-06-02 15:18:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035683002/40001
4 years, 6 months ago (2016-06-02 20:49:47 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-02 21:24:34 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 21:24:51 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/70e302eeddfe8b078b257975b0ad7b9748974f00
Cr-Commit-Position: refs/heads/master@{#36690}

Powered by Google App Engine
This is Rietveld 408576698