Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: src/compiler/code-assembler.h

Issue 2035683002: [turbofan] Fix assert caused by bogus merging of out-of-scope CodeAssembler variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/code-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/code-assembler.h
diff --git a/src/compiler/code-assembler.h b/src/compiler/code-assembler.h
index ab04e7e58e3fb172a287028226745976962e8e73..2a00b040c7c392fce5faeec1e39bc40c40ae9e54 100644
--- a/src/compiler/code-assembler.h
+++ b/src/compiler/code-assembler.h
@@ -166,6 +166,7 @@ class CodeAssembler {
class Variable {
public:
explicit Variable(CodeAssembler* assembler, MachineRepresentation rep);
+ ~Variable();
void Bind(Node* value);
Node* value() const;
MachineRepresentation rep() const;
@@ -175,6 +176,7 @@ class CodeAssembler {
friend class CodeAssembler;
class Impl;
Impl* impl_;
+ CodeAssembler* assembler_;
};
enum AllocationFlag : uint8_t {
@@ -362,7 +364,7 @@ class CodeAssembler {
Code::Flags flags_;
const char* name_;
bool code_generated_;
- ZoneVector<Variable::Impl*> variables_;
+ ZoneSet<Variable::Impl*> variables_;
DISALLOW_COPY_AND_ASSIGN(CodeAssembler);
};
« no previous file with comments | « no previous file | src/compiler/code-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698