Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improved api a bit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
index d3227d099e552ddf79abcec8c15d90f1ccbbeba6..f32d0e536a4994fb7c75f2202689987abfd3d5fd 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
@@ -6,8 +6,7 @@
#define V8DebuggerClient_h
#include "platform/inspector_protocol/Platform.h"
-#include "platform/v8_inspector/public/ConsoleAPITypes.h"
-#include "platform/v8_inspector/public/ConsoleTypes.h"
+#include "platform/v8_inspector/public/V8ConsoleTypes.h"
#include "platform/v8_inspector/public/V8ContextInfo.h"
#include <v8.h>
@@ -19,10 +18,9 @@ public:
virtual ~V8DebuggerClient() { }
virtual void runMessageLoopOnPause(int contextGroupId) = 0;
virtual void quitMessageLoopOnPause() = 0;
+ // TODO(dgozman): we don't really need to mute warnings and deprecations.
virtual void muteWarningsAndDeprecations() = 0;
virtual void unmuteWarningsAndDeprecations() = 0;
- virtual void muteConsole() = 0;
- virtual void unmuteConsole() = 0;
virtual void beginUserGesture() = 0;
virtual void endUserGesture() = 0;
virtual bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) = 0;
@@ -30,17 +28,18 @@ public:
virtual bool formatAccessorsAsProperties(v8::Local<v8::Value>) = 0;
virtual bool isExecutionAllowed() = 0;
virtual double currentTimeMS() = 0;
- virtual int ensureDefaultContextInGroup(int contextGroupId) = 0;
+ virtual v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) = 0;
virtual bool isInspectableHeapObject(v8::Local<v8::Object>) = 0;
virtual void enableAsyncInstrumentation() = 0;
virtual void disableAsyncInstrumentation() = 0;
virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) = 0;
- virtual void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount) = 0;
virtual void consoleTime(const String16& title) = 0;
virtual void consoleTimeEnd(const String16& title) = 0;
virtual void consoleTimeStamp(const String16& title) = 0;
+ // TODO(dgozman: route all messages through here, remove FrameConsole.
+ virtual void messageAddedToConsole(int contextGroupId, MessageSource, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) = 0;
virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) = 0;

Powered by Google App Engine
This is Rietveld 408576698