Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: all tests pass Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
index e7f9bed382349bc0b32e6472c52243f76e168f2c..14bbdd2a80aec44c9a03ee793626e029db3ff48a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
@@ -183,15 +183,17 @@ void V8InjectedScriptHost::suppressWarningsAndCallFunctionCallback(const v8::Fun
}
}
- V8DebuggerClient* client = unwrapDebugger(info)->client();
- client->muteWarningsAndDeprecations();
+ V8DebuggerImpl* debugger = unwrapDebugger(info);
+ debugger->client()->muteWarningsAndDeprecations();
kozy 2016/06/23 22:28:44 TODO:remove mute warnings and deprecations
dgozman 2016/06/28 01:43:48 Done.
+ debugger->muteConsole();
v8::MicrotasksScope microtasks(isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);
v8::Local<v8::Value> result;
if (function->Call(context, receiver, argc, argv.get()).ToLocal(&result))
info.GetReturnValue().Set(result);
- client->unmuteWarningsAndDeprecations();
+ debugger->unmuteConsole();
+ debugger->client()->unmuteWarningsAndDeprecations();
}
void V8InjectedScriptHost::bindCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

Powered by Google App Engine
This is Rietveld 408576698