third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp - Issue 2035653006: [DevTools] Move Console to v8 inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

Issue 2035653006: [DevTools] Move Console to v8 inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: all tests pass Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

index 3281d1ba1dab4802505aa0059f9a20cf6011d7a8..ce6de063361f6069882d6e4bc12446e754452aef 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

@@ -52,7 +52,7 @@ public:

const char* GetName(v8::Local<v8::Object> object) override

{

- int contextId = V8Debugger::contextId(object->CreationContext());

+ int contextId = V8DebuggerImpl::contextId(object->CreationContext());

if (!contextId)

return "";

ErrorString errorString;