third_party/WebKit/Source/devtools/scripts/compile_frontend.py - Issue 2035653005: DevTools: split protocol.json into files per domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/compile_frontend.py

Issue 2035653005: DevTools: split protocol.json into files per domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/PRESUBMIT.py ('K') | « third_party/WebKit/Source/devtools/scripts/CodeGeneratorFrontend.py ('k') | third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py » ('j') | third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/scripts/compile_frontend.py

diff --git a/third_party/WebKit/Source/devtools/scripts/compile_frontend.py b/third_party/WebKit/Source/devtools/scripts/compile_frontend.py

index 828699adfd7e37b3d60de5bdc29b12b0c570be89..d5d6d6ee04fde5b891376645303f8b1495e1b3ef 100755

--- a/third_party/WebKit/Source/devtools/scripts/compile_frontend.py

+++ b/third_party/WebKit/Source/devtools/scripts/compile_frontend.py

@@ -97,7 +97,7 @@ loaded_css_regex = re.compile(r'(?:registerRequiredCSS|WebInspector\.View\.creat

java_build_regex = re.compile(r'^\w+ version "(\d+)\.(\d+)')

errors_found = False

-generate_protocol_externs.generate_protocol_externs(protocol_externs_file, path.join(devtools_path, 'protocol.json'))

+generate_protocol_externs.generate_protocol_externs(protocol_externs_file, path.join(inspector_path, 'protocol'), path.join(v8_inspector_path, 'protocol'))

# Based on http://stackoverflow.com/questions/377017/test-if-executable-exists-in-python.