Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/devtools/PRESUBMIT.py

Issue 2035653005: DevTools: split protocol.json into files per domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/Inspector-1.1.json ('k') | third_party/WebKit/Source/devtools/devtools.gyp » ('j') | third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/PRESUBMIT.py
diff --git a/third_party/WebKit/Source/devtools/PRESUBMIT.py b/third_party/WebKit/Source/devtools/PRESUBMIT.py
index 5baa6cd1c720dd96b2b21bfd1fdce203a6968bf5..d553aa470ce12e09ec92e2ecc10d3cedce331429 100644
--- a/third_party/WebKit/Source/devtools/PRESUBMIT.py
+++ b/third_party/WebKit/Source/devtools/PRESUBMIT.py
@@ -69,7 +69,7 @@ def _CompileDevtoolsFrontend(input_api, output_api):
# should be added to the list of triggers.
devtools_front_end = input_api.os_path.join("devtools", "front_end")
if (any(devtools_front_end in path for path in local_paths) or
- any("protocol.json" in path for path in local_paths) or
+ any(".json" in path for path in local_paths) or
dgozman 2016/06/03 02:24:02 protocol/*.json
pfeldman 2016/06/03 17:07:32 Done.
any("compile_frontend.py" in path for path in local_paths) or
any("InjectedScriptSource.js" in path for path in local_paths)):
dgozman 2016/06/03 02:24:02 While you are here, add DebuggerScript.js
pfeldman 2016/06/03 17:07:32 Done.
lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
« no previous file with comments | « third_party/WebKit/Source/devtools/Inspector-1.1.json ('k') | third_party/WebKit/Source/devtools/devtools.gyp » ('j') | third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version » ('J')

Powered by Google App Engine
This is Rietveld 408576698