Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2996)

Unified Diff: chrome/browser/devtools/devtools_protocol_constants_generator.py

Issue 2035653005: DevTools: split protocol.json into files per domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_protocol_constants_generator.py
diff --git a/chrome/browser/devtools/devtools_protocol_constants_generator.py b/chrome/browser/devtools/devtools_protocol_constants_generator.py
index 7e53ac1c9a13f86d0d6d878c5ca8f600c45d511c..df0201faac89a2e6d1c29628f9b2cb6147b15778 100755
--- a/chrome/browser/devtools/devtools_protocol_constants_generator.py
+++ b/chrome/browser/devtools/devtools_protocol_constants_generator.py
@@ -24,7 +24,7 @@ template_h = string.Template("""\
// THIS FILE IS AUTOGENERATED. DO NOT EDIT.
// Generated by
// chrome/browser/devtools/devtools_protocol_constants_generator.py from
-// third_party/WebKit/Source/devtools/protocol.json and
+// gen/blink/core/inspector/protocol/inspector.json and
// content/browser/devtools/browser_protocol.json
#include <string>
@@ -53,7 +53,7 @@ template_cc = string.Template("""\
// THIS FILE IS AUTOGENERATED. DO NOT EDIT.
// Generated by
// chrome/browser/devtools/devtools_protocol_constants_generator.py from
-// third_party/WebKit/Source/devtools/protocol.json and
+// gen/blink/core/inspector/protocol/inspector.json and
// content/browser/devtools/browser_protocol.json
#include "base/strings/string_number_conversions.h"
@@ -143,18 +143,17 @@ def CreateHeader(tree, output_file):
"PACKAGE": package.upper()
}))
-def CreateBody(tree, version, output_file):
+def CreateBody(tree, output_file):
contents = FormatContents(tree, "", "const char {0}[] = \"{1}\";\n")
output_file.write(template_cc.substitute({
- "major": version["major"],
- "minor": version["minor"],
+ "major": "1",
+ "minor": "1",
"contents": contents,
"package": package
}))
blink_protocol_data = open(blink_protocol_path).read()
blink_protocol = json.loads(blink_protocol_data)
-blink_version = blink_protocol["version"]
domains = blink_protocol["domains"]
@@ -206,7 +205,7 @@ for (namespace_name, namespace) in namespace_tree.items():
namespace["kName"] = namespace_name
with open(output_cc_path, "w") as f:
- CreateBody(namespace_tree, blink_version, f)
+ CreateBody(namespace_tree, f)
with open(output_h_path, "w") as f:
CreateHeader(namespace_tree, f)

Powered by Google App Engine
This is Rietveld 408576698