Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2035533003: Move test/cctest/compiler/test-code-stub-assembler.cc to test/cctest directory. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move test/cctest/compiler/test-code-stub-assembler.cc to test/cctest directory. ... since CodeStubAssembler does not belong to v8::internal::compiler namespace anymore. Committed: https://crrev.com/5a5c115efdc0058618d9bb66e84ef88b6501e0d8 Cr-Commit-Position: refs/heads/master@{#36683}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -405 lines) Patch
M test/cctest/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
D test/cctest/compiler/test-code-stub-assembler.cc View 1 chunk +0 lines, -394 lines 0 comments Download
A + test/cctest/test-code-stub-assembler.cc View 9 chunks +2 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035533003/1
4 years, 6 months ago (2016-06-02 12:46:28 UTC) #3
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-02 12:46:38 UTC) #5
Jakob Kummerow
lgtm
4 years, 6 months ago (2016-06-02 12:52:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035533003/1
4 years, 6 months ago (2016-06-02 12:54:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/15349)
4 years, 6 months ago (2016-06-02 13:35:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2035533003/20001
4 years, 6 months ago (2016-06-02 13:42:07 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 14:07:47 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 14:10:05 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a5c115efdc0058618d9bb66e84ef88b6501e0d8
Cr-Commit-Position: refs/heads/master@{#36683}

Powered by Google App Engine
This is Rietveld 408576698