Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2034463003: Make CodeStubAssemblerTester use its own zone instead of Isolate::runtime_zone(). (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@move-csa-test
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make CodeStubAssemblerTester use its own zone instead of Isolate::runtime_zone(). ... to ensure that the zone is properly shut down. Committed: https://crrev.com/e7d8279a14c17195fc3ef295b77948fcf26a75b7 Cr-Commit-Position: refs/heads/master@{#36684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M test/cctest/test-code-stub-assembler.cc View 1 chunk +16 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034463003/1
4 years, 6 months ago (2016-06-02 13:32:29 UTC) #2
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-02 13:32:36 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/15357) v8_linux_mipsel_compile_rel on ...
4 years, 6 months ago (2016-06-02 13:33:36 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034463003/20001
4 years, 6 months ago (2016-06-02 13:43:36 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 14:09:36 UTC) #11
Jakob Kummerow
lgtm
4 years, 6 months ago (2016-06-02 14:21:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034463003/20001
4 years, 6 months ago (2016-06-02 14:21:55 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-02 14:23:57 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 14:25:31 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7d8279a14c17195fc3ef295b77948fcf26a75b7
Cr-Commit-Position: refs/heads/master@{#36684}

Powered by Google App Engine
This is Rietveld 408576698