Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2035483002: Fix shelf alignment locking for power button. (Closed)

Created:
4 years, 6 months ago by msw
Modified:
4 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix shelf alignment locking for power button. Only lock the shelf once the lock animation starts. (do not lock earlier, on the pre-lock animation start) Add Alt-L (Lock) and Alt-P (Power) --ash-debug-shortcuts. BUG=614042 TEST=Quickly tapping power/lock doesn't lock the shelf. R=oshima@chromium.org Review-Url: https://codereview.chromium.org/2013933002 Cr-Commit-Position: refs/heads/master@{#396599} (cherry picked from commit dbd05211a0cbffa1bcd40888503c2cffeeb0d8ea) Committed: https://chromium.googlesource.com/chromium/src/+/136633328b3c7b2f46be0fe238644191922a80b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ash/accelerators/accelerator_table.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ash/shelf/shelf_locking_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
msw
4 years, 6 months ago (2016-06-01 22:17:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
136633328b3c7b2f46be0fe238644191922a80b7.

Powered by Google App Engine
This is Rietveld 408576698