Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2013933002: Fix shelf alignment locking for power button. (Closed)

Created:
4 years, 7 months ago by msw
Modified:
4 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix shelf alignment locking for power button. Only lock the shelf once the lock animation starts. (do not lock earlier, on the pre-lock animation start) Add Alt-L (Lock) and Alt-P (Power) --ash-debug-shortcuts. BUG=614042 TEST=Quickly tapping power/lock doesn't lock the shelf. R=oshima@chromium.org Committed: https://crrev.com/dbd05211a0cbffa1bcd40888503c2cffeeb0d8ea Cr-Commit-Position: refs/heads/master@{#396599}

Patch Set 1 #

Patch Set 2 : Workaround compositor.cc crash for local testing. #

Patch Set 3 : Cleanup. #

Patch Set 4 : Remove compositor DCHECK workaround. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ash/accelerators/accelerator_table.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M ash/shelf/shelf_locking_manager.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
msw
Hey Oshima, please take a look; thanks!
4 years, 6 months ago (2016-05-27 18:23:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013933002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013933002/60001
4 years, 6 months ago (2016-05-27 18:24:23 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 19:45:39 UTC) #7
oshima
On 2016/05/27 19:45:39, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 6 months ago (2016-05-27 23:24:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013933002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013933002/60001
4 years, 6 months ago (2016-05-27 23:33:54 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-27 23:38:14 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 23:39:23 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dbd05211a0cbffa1bcd40888503c2cffeeb0d8ea
Cr-Commit-Position: refs/heads/master@{#396599}

Powered by Google App Engine
This is Rietveld 408576698