components/autofill/core/common/save_password_progress_logger.h - Issue 2035143002: Basic implementation of showing password fill dialog on page load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.h

Issue 2035143002: Basic implementation of showing password fill dialog on page load (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix iOS compile Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/autofill_switches.cc ('k') | components/autofill/core/common/save_password_progress_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.h

diff --git a/components/autofill/core/common/save_password_progress_logger.h b/components/autofill/core/common/save_password_progress_logger.h

index f1db9ca30fd51bc154424c59d35df6c339c7888a..4407c11dd220710bfe2adc05d701c8b4d10349cd 100644

--- a/components/autofill/core/common/save_password_progress_logger.h

+++ b/components/autofill/core/common/save_password_progress_logger.h

@@ -107,6 +107,7 @@ class SavePasswordProgressLogger {

STRING_SHOW_PASSWORD_PROMPT,

STRING_PASSWORDMANAGER_AUTOFILL,

STRING_PASSWORDMANAGER_AUTOFILLHTTPAUTH,

+ STRING_PASSWORDMANAGER_SHOW_INITIAL_PASSWORD_ACCOUNT_SUGGESTIONS,

STRING_WAIT_FOR_USERNAME,

STRING_LOGINMODELOBSERVER_PRESENT,

STRING_WAS_LAST_NAVIGATION_HTTP_ERROR_METHOD,

@@ -132,6 +133,7 @@ class SavePasswordProgressLogger {

STRING_FORM_MANAGER_STATE,

STRING_UNOWNED_INPUTS_VISIBLE,

STRING_ON_FILL_PASSWORD_FORM_METHOD,

+ STRING_ON_SHOW_INITIAL_PASSWORD_ACCOUNT_SUGGESTIONS,

STRING_AMBIGUOUS_OR_EMPTY_NAMES,

STRING_NUMBER_OF_POTENTIAL_FORMS_TO_FILL,

STRING_CONTAINS_FILLABLE_USERNAME_FIELD,