components/autofill/core/common/save_password_progress_logger.cc - Issue 2035143002: Basic implementation of showing password fill dialog on page load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 2035143002: Basic implementation of showing password fill dialog on page load (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix iOS compile Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/content/browser/content_password_manager_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index ddc55f42893ba718cda0ed9f5cd4e347f347ce6a..1c13e464e665358e98f1e2eeebc24d05a1d43a4e 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -305,6 +305,9 @@ std::string SavePasswordProgressLogger::GetStringFromID(

return "PasswordManager::Autofill";

case SavePasswordProgressLogger::STRING_PASSWORDMANAGER_AUTOFILLHTTPAUTH:

return "PasswordManager::AutofillHttpAuth";

+ case SavePasswordProgressLogger::

+ STRING_PASSWORDMANAGER_SHOW_INITIAL_PASSWORD_ACCOUNT_SUGGESTIONS:

+ return "PasswordManager::ShowInitialPasswordAccountSuggestions";

case SavePasswordProgressLogger::STRING_WAIT_FOR_USERNAME:

return "wait_for_username";

case SavePasswordProgressLogger::STRING_LOGINMODELOBSERVER_PRESENT:

@@ -359,6 +362,9 @@ std::string SavePasswordProgressLogger::GetStringFromID(

"visible";

case SavePasswordProgressLogger::STRING_ON_FILL_PASSWORD_FORM_METHOD:

return "PasswordAutofillAgent::OnFillPasswordForm";

+ case SavePasswordProgressLogger::

+ STRING_ON_SHOW_INITIAL_PASSWORD_ACCOUNT_SUGGESTIONS:

+ return "AutofillAgent::OnShowInitialPasswordAccountSuggestions";

case SavePasswordProgressLogger::STRING_AMBIGUOUS_OR_EMPTY_NAMES:

return "ambiguous_or_empty_names";

case SavePasswordProgressLogger::STRING_NUMBER_OF_POTENTIAL_FORMS_TO_FILL: