Basic implementation of showing password fill dialog on page load

components/autofill/content/renderer/password_autofill_agent.h

Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index 5d430e0b830ff048bab52bf2bbcce994f1e925ee..04dea679f3f7fbe46e83dad65f68122d22c4f73a 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -85,6 +85,12 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
   // JavaScript.
   void FirstUserGestureObserved();
 
+  void GetFillableElementFromFormData(

[vabr (Chromium), 2016/06/10 14:19:51]

nit: Please add a comment explaining the effect of this method and meaning of
its arguments.

[jww, 2016/06/10 23:06:54]

Done. I've also refactored the code for this a bit. namely, I removed the
"should_fill_forms" bit, and I've made OnFillPasswordForm do that work instead,
since it's really only specific to that function. I'm pretty sure that it's a
good change (and, of course, the tests pass), but it would still be great if you
could take a look to the most recent change in password_autofill_agent.cc to
make sure that it passes muster. Thanks!

[vabr (Chromium), 2016/06/13 08:46:41]

Acknowledged, that sounds like an improvement to me!

+      int key,
+      const PasswordFormFillData& form_data,
+      bool should_fill_forms,
+      std::vector<blink::WebInputElement>* elements);
+
  protected:
   virtual bool OriginCanAccessPasswordManager(
       const blink::WebSecurityOrigin& origin);