Basic implementation of showing password fill dialog on page load

components/autofill/content/renderer/password_autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 
 #include <map>
 #include <memory>
 #include <vector>
@@ skipping 67 matching lines @@
 
   // Called when an AJAX has succesfully completed. Used to determine if
   // a form has been submitted by AJAX without navigation.
   void AJAXSucceeded();
 
   // Called when the user first interacts with the page after a load. This is a
   // signal to make autofilled values of password input elements accessible to
   // JavaScript.
   void FirstUserGestureObserved();
 
+  void GetFillableElementFromFormData(

[vabr (Chromium), 2016/06/10 14:19:51]

nit: Please add a comment explaining the effect of this method and meaning of
its arguments.

[jww, 2016/06/10 23:06:54]

Done. I've also refactored the code for this a bit. namely, I removed the
"should_fill_forms" bit, and I've made OnFillPasswordForm do that work instead,
since it's really only specific to that function. I'm pretty sure that it's a
good change (and, of course, the tests pass), but it would still be great if you
could take a look to the most recent change in password_autofill_agent.cc to
make sure that it passes muster. Thanks!

[vabr (Chromium), 2016/06/13 08:46:41]

Acknowledged, that sounds like an improvement to me!

+      int key,
+      const PasswordFormFillData& form_data,
+      bool should_fill_forms,
+      std::vector<blink::WebInputElement>* elements);
+
  protected:
   virtual bool OriginCanAccessPasswordManager(
       const blink::WebSecurityOrigin& origin);
 
  private:
   // Ways to restrict which passwords are saved in ProvisionallySavePassword.
   enum ProvisionallySaveRestriction {
     RESTRICTION_NONE,
     RESTRICTION_NON_EMPTY_PASSWORD
   };
@@ skipping 141 matching lines @@
   // Contains server predictions for username, password and/or new password
   // fields for individual forms.
   FormsPredictionsMap form_predictions_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_