Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 203513002: Move WebGraphicsContext3D related tests from web/tests/ to platform/graphics/gpu/ (Closed)

Created:
6 years, 9 months ago by dshwang
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move WebGraphicsContext3D related tests from web/tests/ to platform/graphics/gpu/ Move Canvas2DLayerBridgeTest.cpp, Canvas2DLayerManagerTest.cpp and DrawingBufferTest.cpp. BUG=353585 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1056 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A + Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/Canvas2DLayerManagerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/graphics/gpu/DrawingBufferTest.cpp View 3 chunks +1 line, -5 lines 0 comments Download
A + Source/platform/graphics/test/MockWebGraphicsContext3D.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D Source/web/tests/Canvas2DLayerBridgeTest.cpp View 1 chunk +0 lines, -166 lines 0 comments Download
D Source/web/tests/Canvas2DLayerManagerTest.cpp View 1 chunk +0 lines, -339 lines 0 comments Download
D Source/web/tests/DrawingBufferTest.cpp View 1 chunk +0 lines, -247 lines 0 comments Download
D Source/web/tests/MockWebGraphicsContext3D.h View 1 chunk +0 lines, -294 lines 0 comments Download
M Source/web/web.gypi View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dshwang
could you review?
6 years, 9 months ago (2014-03-18 16:04:34 UTC) #1
jamesr
lgtm. thanks!
6 years, 9 months ago (2014-03-18 19:19:35 UTC) #2
dshwang
On 2014/03/18 19:19:35, jamesr wrote: > lgtm. thanks! thank you for review!
6 years, 9 months ago (2014-03-18 20:53:11 UTC) #3
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 9 months ago (2014-03-18 20:53:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/203513002/1
6 years, 9 months ago (2014-03-18 20:53:31 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 21:04:28 UTC) #6
Message was sent while issue was closed.
Change committed as 169474

Powered by Google App Engine
This is Rietveld 408576698