third_party/WebKit/Source/core/frame/ImageBitmap.h - Issue 2035113002: Implement ImageBitmapOptions resize

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.h

Issue 2035113002: Implement ImageBitmapOptions resize (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-resize.html ('k') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('j') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/ImageBitmap.h

diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.h b/third_party/WebKit/Source/core/frame/ImageBitmap.h

index 1e6e3db9db56924decb8f44f2124148eb065a267..7bffed47e6c9bdd91493b4123369c4f093937e4b 100644

--- a/third_party/WebKit/Source/core/frame/ImageBitmap.h

+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.h

@@ -31,6 +31,15 @@ enum AlphaDisposition {

DontPremultiplyAlpha,

};

+struct ParsedOptions {

+ bool flipY;

jbroman 2016/06/30 18:52:34 nit: for predictability, mind providing default va

xidachen 2016/07/07 13:48:47 Done.

+ bool premultiplyAlpha;

+ bool shouldScaleInput;

+ unsigned resizeWidth;

+ unsigned resizeHeight;

+ SkFilterQuality resizeQuality;

+};

class CORE_EXPORT ImageBitmap final : public GarbageCollectedFinalized<ImageBitmap>, public ScriptWrappable, public CanvasImageSource, public ImageBitmapSource {

DEFINE_WRAPPERTYPEINFO();

public:

@@ -79,16 +88,16 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- ImageBitmap(HTMLImageElement*, const IntRect&, Document*, const ImageBitmapOptions&);

- ImageBitmap(HTMLVideoElement*, const IntRect&, Document*, const ImageBitmapOptions&);

- ImageBitmap(HTMLCanvasElement*, const IntRect&, const ImageBitmapOptions&);

- ImageBitmap(ImageData*, const IntRect&, const ImageBitmapOptions&, const bool&, const bool&);

- ImageBitmap(ImageBitmap*, const IntRect&, const ImageBitmapOptions&);

+ ImageBitmap(HTMLImageElement*, IntRect&, Document*, const ImageBitmapOptions&);

+ ImageBitmap(HTMLVideoElement*, IntRect&, Document*, const ImageBitmapOptions&);

+ ImageBitmap(HTMLCanvasElement*, IntRect&, const ImageBitmapOptions&);

+ ImageBitmap(ImageData*, IntRect&, const ImageBitmapOptions&, const bool&, const bool&);

+ ImageBitmap(ImageBitmap*, IntRect&, const ImageBitmapOptions&);

ImageBitmap(PassRefPtr<StaticBitmapImage>);

- ImageBitmap(PassRefPtr<StaticBitmapImage>, const IntRect&, const ImageBitmapOptions&);

+ ImageBitmap(PassRefPtr<StaticBitmapImage>, IntRect&, const ImageBitmapOptions&);

ImageBitmap(WebExternalTextureMailbox&);

- void parseOptions(const ImageBitmapOptions&, bool&, bool&);

+ ParsedOptions parseOptions(const ImageBitmapOptions&, const int, const int);

RefPtr<StaticBitmapImage> m_image;

bool m_isNeutered = false;