third_party/WebKit/Source/core/frame/ImageBitmap.h - Issue 2035113002: Implement ImageBitmapOptions resize

Side by Side Diff: third_party/WebKit/Source/core/frame/ImageBitmap.h

Issue 2035113002: Implement ImageBitmapOptions resize (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-resize.html ('k') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('j') | third_party/WebKit/Source/core/frame/ImageBitmap.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ImageBitmap_h	5 #ifndef ImageBitmap_h

6 #define ImageBitmap_h	6 #define ImageBitmap_h

7	7

8 #include "bindings/core/v8/ScriptWrappable.h"	8 #include "bindings/core/v8/ScriptWrappable.h"

9 #include "core/CoreExport.h"	9 #include "core/CoreExport.h"

10 #include "core/html/HTMLImageElement.h"	10 #include "core/html/HTMLImageElement.h"

(...skipping 13 matching lines...) Expand all Loading...
24 class HTMLCanvasElement;	24 class HTMLCanvasElement;

25 class HTMLVideoElement;	25 class HTMLVideoElement;

26 class ImageData;	26 class ImageData;

27 class ImageDecoder;	27 class ImageDecoder;

28	28

29 enum AlphaDisposition {	29 enum AlphaDisposition {

30 PremultiplyAlpha,	30 PremultiplyAlpha,

31 DontPremultiplyAlpha,	31 DontPremultiplyAlpha,

32 };	32 };

33	33

	34 struct ParsedOptions {

	35 bool flipY;
	jbroman 2016/06/30 18:52:34 nit: for predictability, mind providing default va nit: for predictability, mind providing default values for these? "bool flipY = false;" etc? Else if one isn't initialized, some unpredictable value will be observed instead. xidachen 2016/07/07 13:48:47 Done. Show quoted text On 2016/06/30 18:52:34, jbroman wrote: > nit: for predictability, mind providing default values for these? > > "bool flipY = false;" etc? > > Else if one isn't initialized, some unpredictable value will be observed > instead. Done.
	36 bool premultiplyAlpha;

	37 bool shouldScaleInput;

	38 unsigned resizeWidth;

	39 unsigned resizeHeight;

	40 SkFilterQuality resizeQuality;

	41 };

	42

34 class CORE_EXPORT ImageBitmap final : public GarbageCollectedFinalized<ImageBitm ap>, public ScriptWrappable, public CanvasImageSource, public ImageBitmapSource {	43 class CORE_EXPORT ImageBitmap final : public GarbageCollectedFinalized<ImageBitm ap>, public ScriptWrappable, public CanvasImageSource, public ImageBitmapSource {

35 DEFINE_WRAPPERTYPEINFO();	44 DEFINE_WRAPPERTYPEINFO();

36 public:	45 public:

37 static ImageBitmap* create(HTMLImageElement, const IntRect&, Document, con st ImageBitmapOptions& = ImageBitmapOptions());	46 static ImageBitmap* create(HTMLImageElement, const IntRect&, Document, con st ImageBitmapOptions& = ImageBitmapOptions());

38 static ImageBitmap* create(HTMLVideoElement, const IntRect&, Document, con st ImageBitmapOptions& = ImageBitmapOptions());	47 static ImageBitmap* create(HTMLVideoElement, const IntRect&, Document, con st ImageBitmapOptions& = ImageBitmapOptions());

39 static ImageBitmap* create(HTMLCanvasElement*, const IntRect&, const ImageBi tmapOptions& = ImageBitmapOptions());	48 static ImageBitmap* create(HTMLCanvasElement*, const IntRect&, const ImageBi tmapOptions& = ImageBitmapOptions());

40 static ImageBitmap* create(ImageData*, const IntRect&, const ImageBitmapOpti ons& = ImageBitmapOptions(), const bool& isImageDataPremultiplied = false, const bool& isImageDataOriginClean = true);	49 static ImageBitmap* create(ImageData*, const IntRect&, const ImageBitmapOpti ons& = ImageBitmapOptions(), const bool& isImageDataPremultiplied = false, const bool& isImageDataOriginClean = true);

41 static ImageBitmap* create(ImageBitmap*, const IntRect&, const ImageBitmapOp tions& = ImageBitmapOptions());	50 static ImageBitmap* create(ImageBitmap*, const IntRect&, const ImageBitmapOp tions& = ImageBitmapOptions());

42 static ImageBitmap* create(PassRefPtr<StaticBitmapImage>);	51 static ImageBitmap* create(PassRefPtr<StaticBitmapImage>);

43 static ImageBitmap* create(PassRefPtr<StaticBitmapImage>, const IntRect&, co nst ImageBitmapOptions& = ImageBitmapOptions());	52 static ImageBitmap* create(PassRefPtr<StaticBitmapImage>, const IntRect&, co nst ImageBitmapOptions& = ImageBitmapOptions());

(...skipping 28 matching lines...) Expand all Loading...
72 int sourceWidth() override { return m_image ? m_image->width() : 0; }	81 int sourceWidth() override { return m_image ? m_image->width() : 0; }

73 int sourceHeight() override { return m_image ? m_image->height() : 0; }	82 int sourceHeight() override { return m_image ? m_image->height() : 0; }

74	83

75 // ImageBitmapSource implementation	84 // ImageBitmapSource implementation

76 IntSize bitmapSourceSize() const override { return size(); }	85 IntSize bitmapSourceSize() const override { return size(); }

77 ScriptPromise createImageBitmap(ScriptState*, EventTarget&, int sx, int sy, int sw, int sh, const ImageBitmapOptions&, ExceptionState&) override;	86 ScriptPromise createImageBitmap(ScriptState*, EventTarget&, int sx, int sy, int sw, int sh, const ImageBitmapOptions&, ExceptionState&) override;

78	87

79 DECLARE_VIRTUAL_TRACE();	88 DECLARE_VIRTUAL_TRACE();

80	89

81 private:	90 private:

82 ImageBitmap(HTMLImageElement, const IntRect&, Document, const ImageBitmapO ptions&);	91 ImageBitmap(HTMLImageElement, IntRect&, Document, const ImageBitmapOptions &);

83 ImageBitmap(HTMLVideoElement, const IntRect&, Document, const ImageBitmapO ptions&);	92 ImageBitmap(HTMLVideoElement, IntRect&, Document, const ImageBitmapOptions &);

84 ImageBitmap(HTMLCanvasElement*, const IntRect&, const ImageBitmapOptions&);	93 ImageBitmap(HTMLCanvasElement*, IntRect&, const ImageBitmapOptions&);

85 ImageBitmap(ImageData*, const IntRect&, const ImageBitmapOptions&, const boo l&, const bool&);	94 ImageBitmap(ImageData*, IntRect&, const ImageBitmapOptions&, const bool&, co nst bool&);

86 ImageBitmap(ImageBitmap*, const IntRect&, const ImageBitmapOptions&);	95 ImageBitmap(ImageBitmap*, IntRect&, const ImageBitmapOptions&);

87 ImageBitmap(PassRefPtr<StaticBitmapImage>);	96 ImageBitmap(PassRefPtr<StaticBitmapImage>);

88 ImageBitmap(PassRefPtr<StaticBitmapImage>, const IntRect&, const ImageBitmap Options&);	97 ImageBitmap(PassRefPtr<StaticBitmapImage>, IntRect&, const ImageBitmapOption s&);

89 ImageBitmap(WebExternalTextureMailbox&);	98 ImageBitmap(WebExternalTextureMailbox&);

90	99

91 void parseOptions(const ImageBitmapOptions&, bool&, bool&);	100 ParsedOptions parseOptions(const ImageBitmapOptions&, const int, const int);

92	101

93 RefPtr<StaticBitmapImage> m_image;	102 RefPtr<StaticBitmapImage> m_image;

94 bool m_isNeutered = false;	103 bool m_isNeutered = false;

95 };	104 };

96	105

97 } // namespace blink	106 } // namespace blink

98	107

99 #endif // ImageBitmap_h	108 #endif // ImageBitmap_h

OLD	NEW