Fix Hiding Issue with Certificate Viewer Mac

Fix Hiding Issue with Certificate Viewer Mac

Add removed code from https://codereview.chromium.org/1495623008
that changes the position of the viewer when it hides/unhides.

Added logic that calculates the x and y position offset of the dialog
when it unhides.

BUG=611603
Committed: https://crrev.com/8fba1d4d58b4e12b1b99df85caf36332bdb4dc07
Cr-Commit-Position: refs/heads/master@{#397756}

[spqchan, 2016-06-03 01:16:54]

Description was changed from

==========
Fix Hiding Issue with Certificate Viewer Mac



BUG=
==========

to

==========
Fix Hiding Issue with Certificate Viewer Mac

Add removed code from https://codereview.chromium.org/1495623008
that changes the position of the viewer when it hides/unhides.

Added logic that calculates the x and y position offset of the dialog
when it unhides.

BUG=611603
==========

[spqchan, 2016-06-03 01:16:55]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-06-03 01:30:10]

PTAL

Sorry for causing the issue with the code removal. The reason why I removed the
code was because it was causing an issue where the certificate viewer would be
in the incorrect position if you resize the window when the viewer dialog is
hidden. 

I added the code back and added some logic that would put the dialog in the
correct position if the window was resized before unhide was called. Would this
be the correct approach? Thanks!

https://codereview.chromium.org/2034993002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (left):

https://codereview.chromium.org/2034993002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:752: [self
setSheetHiddenForFullscreenTransition:NO];
Removing this because it's redundant. (This was getting called a second time
inside resetCustomAppKitFullscreenVariables: at line 760)

[Avi (use Gerrit), 2016-06-03 01:34:21]

That looks reasonable to me. LGTM

No apologies needed. The resizing's reason was a bit subtle, and easy to miss.

[spqchan, 2016-06-03 01:41:21]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-06-03 01:42:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034993002/20001

[commit-bot: I haz the power, 2016-06-03 03:18:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 03:18:25]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[spqchan, 2016-06-03 17:20:26]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-06-03 17:20:26]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2034993002/#ps40001
(title: "revert the old CL's change on the browser test")

[commit-bot: I haz the power, 2016-06-03 17:20:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034993002/40001

[commit-bot: I haz the power, 2016-06-03 18:13:49]

Description was changed from

==========
Fix Hiding Issue with Certificate Viewer Mac

Add removed code from https://codereview.chromium.org/1495623008
that changes the position of the viewer when it hides/unhides.

Added logic that calculates the x and y position offset of the dialog
when it unhides.

BUG=611603
==========

to

==========
Fix Hiding Issue with Certificate Viewer Mac

Add removed code from https://codereview.chromium.org/1495623008
that changes the position of the viewer when it hides/unhides.

Added logic that calculates the x and y position offset of the dialog
when it unhides.

BUG=611603
==========

[commit-bot: I haz the power, 2016-06-03 18:13:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 18:15:35]

Description was changed from

==========
Fix Hiding Issue with Certificate Viewer Mac

Add removed code from https://codereview.chromium.org/1495623008
that changes the position of the viewer when it hides/unhides.

Added logic that calculates the x and y position offset of the dialog
when it unhides.

BUG=611603
==========

to

==========
Fix Hiding Issue with Certificate Viewer Mac

Add removed code from https://codereview.chromium.org/1495623008
that changes the position of the viewer when it hides/unhides.

Added logic that calculates the x and y position offset of the dialog
when it unhides.

BUG=611603

Committed: https://crrev.com/8fba1d4d58b4e12b1b99df85caf36332bdb4dc07
Cr-Commit-Position: refs/heads/master@{#397756}
==========

[commit-bot: I haz the power, 2016-06-03 18:15:36]

Patchset 3 (id:??) landed as
https://crrev.com/8fba1d4d58b4e12b1b99df85caf36332bdb4dc07
Cr-Commit-Position: refs/heads/master@{#397756}