chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm - Issue 2034993002: Fix Hiding Issue with Certificate Viewer Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

Issue 2034993002: Fix Hiding Issue with Certificate Viewer Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert the old CL's change on the browser test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm b/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

index ca0fc71d510e147f69a1c48997409d9fba78f83b..fd425108141b8bbf6644436e80979904e6c07df2 100644

--- a/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

+++ b/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm

@@ -71,7 +71,7 @@ IN_PROC_BROWSER_TEST_F(SSLCertificateViewerCocoaTest, HideShow) {

// Switch to another tab and verify that the sheet is hidden.

AddBlankTabAndShow(browser());

EXPECT_EQ(0.0, [sheetWindow alphaValue]);

- EXPECT_NSEQ(sheetFrame, [sheetWindow frame]);

+ EXPECT_NSEQ(ui::kWindowSizeDeterminedLater, [sheetWindow frame]);

// Switch back and verify that the sheet is shown.

chrome::SelectNumberedTab(browser(), 0);

« no previous file with comments | « chrome/browser/ui/cocoa/certificate_viewer_mac.mm ('k') | no next file » | no next file with comments »